Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dup and clone for JSON::Any and YAML::Any #6266

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

asterite
Copy link
Member

Fixes #6220

Please don't ask me code examples on these ones, they are trivially understood.

Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@@ -2,6 +2,8 @@ module Crystal::Doc::Highlighter
extend self

def highlight(code)
compiler = Compiler.new
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was a good idea... but yeah, let's remove this.

@asterite asterite force-pushed the feature/6220-json-any-dup branch from cf58748 to 657a084 Compare June 26, 2018 09:09
@bcardiff bcardiff added this to the 0.25.1 milestone Jun 26, 2018
@bcardiff bcardiff merged commit 0004179 into crystal-lang:master Jun 26, 2018
@asterite asterite deleted the feature/6220-json-any-dup branch June 26, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants