Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: add missing document for ArrayLiteral#push and #unshift #6232

Conversation

makenowjust
Copy link
Contributor

Why are these methods hiding?

@bcardiff
Copy link
Member

Because they are added in a far different place probably.

I hope they are removed actually thank to annotation. But for know it's better to have them in docs.

Thanks!

@bcardiff bcardiff added this to the 0.25.1 milestone Jun 21, 2018
@bcardiff
Copy link
Member

@Sija My motivations for such statement is that it makes harder to have a more incremental compilation eventually, because for understanding a macro evaluation you need to repeat the whole history since there is global state that could have change. We are far still, but the idea is lurking around.

@bcardiff bcardiff merged commit fd628c9 into crystal-lang:master Jun 21, 2018
@Sija
Copy link
Contributor

Sija commented Jun 21, 2018

@bcardiff I see, thanks for clearing up my confusion. I'd love incremental compilation, yet its implementation lefts a lot to discuss.

@makenowjust makenowjust deleted the fix/macro/add-doc-for-array-mutational-methods branch June 21, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants