Improve documentation of String#% #6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxhuvud
reviewed
May 14, 2018
src/string.cr
Outdated
| # "Party like it's %d!!!" % 1999 # => "Party like it's 1999!!!" | ||
| # "I have %d apples" % 5 # => "I have 5 apples" | ||
| # "%s, %s, %s, D" % ['A', 'B', 'C'] # => "A, B, C, D" | ||
| # "sum: %{one} + %{two} = %{three}" % ({one: 1, two: 2, three: 1 + 2}) # => "sum: 1 + 2 = 3" |
There was a problem hiding this comment.
There is also "test%<x>s" % {x: 4} # => "test4"
There was a problem hiding this comment.
Also, what are those ()s doing there? They are totally not needed.
There was a problem hiding this comment.
Oh it looks like these parentheses got there for some reason when I compiled:
pp "sum: %{one} + %{two} = %{three}" % {one: 1, two: 2, three: 1 + 2}"sum: %{one} + %{two} = %{three}" % ({one: 1, two: 2, three: 1 + 2}) # => "sum: 1 + 2 = 3"
Thats weird.
RX14
approved these changes
May 16, 2018
sdogruyol
approved these changes
May 17, 2018
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.