Allow private method invocation with self receiver #6075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
May 8, 2018
sdogruyol
approved these changes
May 8, 2018
sdogruyol
added
topic:compiler
kind:bug
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5995
I was surprised there is no spec for checking this. All specs are passed even if calling private method with
selfreceiver is allowed.IMHO it is not so problem to allow this. This change makes
privatevisibility rule complex, butprotectedis more complex than that still. And there is no reason not to allow this in statically typed programming language like Crystal.Additionally I don't know and can't find the case breaking compatibility for this change. Perhaps it is so little.
Thank you.