Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark .editorconfig as root #6031

Merged
merged 3 commits into from
May 1, 2018

Conversation

makenowjust
Copy link
Contributor

I think .editorconfig in project root should set root = true and almost all projects do such. Why not crystal-lang/crystal do?

@@ -80,6 +80,8 @@ module Crystal
{"example", "example_app", "example-lib", "camel_example-camel_lib"}.each do |name|
describe_file "#{name}/.editorconfig" do |editorconfig|
parsed = INI.parse(editorconfig)
# TODO: remove comment out after next release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't this be uncommentedf now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't understand Hash shape returned by INI.parse. I'll fix it.

@sdogruyol sdogruyol merged commit a56f370 into crystal-lang:master May 1, 2018
@RX14 RX14 added this to the Next milestone May 3, 2018
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:infrastructure topic:tools labels May 3, 2018
chris-huxtable pushed a commit to chris-huxtable/crystal that referenced this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:infrastructure topic:tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants