-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI distribution scripts #5839
Conversation
@@ -45,7 +45,7 @@ jobs: | |||
- run: | | |||
git clone https://github.com/crystal-lang/distribution-scripts.git ~/distribution-scripts | |||
cd ~/distribution-scripts | |||
git checkout 839e8ce63e5c48393faa0c126dd2f42aa5c798aa | |||
git checkout bc320f21edb40622ec0e294995c8dc42e0e81f17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a branch instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure the distribution scripts should not just follow a branch but be updated explicitly (and don't lose that information). The value here should always point to a single commit, either a hash or tag. But I don't think a tag would be really useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, because there is a dependency that the circle config and the distribution scripts have to be the same or compatible versions.
The original idea was tags but I said if you're just going to tag it and use it in one place why not just use the sha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a special tag is used instead of a hash, to update we will only delete and tag again instead of creating a commit that changes the hash. But I don't know if it is a good practise.
Ping, would be nice to get this reviewed. |
Ping again. |
See crystal-lang/distribution-scripts@bc320f2.
Updates libgc to use the large configuration, recommended for applications using >512MiB of ram (lol).
Fixes #5610