Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI distribution scripts #5839

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Mar 18, 2018

See crystal-lang/distribution-scripts@bc320f2.

Updates libgc to use the large configuration, recommended for applications using >512MiB of ram (lol).

Fixes #5610

@RX14 RX14 added kind:feature topic:infrastructure kind:bug A bug in the code. Does not apply to documentation, specs, etc. and removed kind:feature labels Mar 18, 2018
@@ -45,7 +45,7 @@ jobs:
- run: |
git clone https://github.com/crystal-lang/distribution-scripts.git ~/distribution-scripts
cd ~/distribution-scripts
git checkout 839e8ce63e5c48393faa0c126dd2f42aa5c798aa
git checkout bc320f21edb40622ec0e294995c8dc42e0e81f17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a branch instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the distribution scripts should not just follow a branch but be updated explicitly (and don't lose that information). The value here should always point to a single commit, either a hash or tag. But I don't think a tag would be really useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, because there is a dependency that the circle config and the distribution scripts have to be the same or compatible versions.

The original idea was tags but I said if you're just going to tag it and use it in one place why not just use the sha.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a special tag is used instead of a hash, to update we will only delete and tag again instead of creating a commit that changes the hash. But I don't know if it is a good practise.

@RX14
Copy link
Contributor Author

RX14 commented Mar 31, 2018

Ping, would be nice to get this reviewed.

@RX14
Copy link
Contributor Author

RX14 commented Apr 11, 2018

Ping again.

@RX14 RX14 added this to the Next milestone Apr 12, 2018
@RX14 RX14 merged commit e7860df into crystal-lang:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants