Semantic: Allow macro overload on named args #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bew
force-pushed
the
allow-macro-overload-on-named-args
branch
from
0c61cb9 to
9f894c1
Compare
RX14
reviewed
Mar 19, 2018
| it "something between 2 macros (I need a name!!!)" do | ||
| assert_type(%( | ||
| macro foo(*, arg1) | ||
| {{ arg1 }} |
There was a problem hiding this comment.
Perhaps use 1 and 1_i64 for these two so the spec can tell if the compiler uses the other overload.
There was a problem hiding this comment.
I used 1 and "foo", as I find it easier to directly see the difference in type of these two literals!
| !!double_splat == !!other.double_splat | ||
| # If they have different number of arguments, splat index or presence of | ||
| # double splat, no override. | ||
| unless args.size == other.args.size && |
There was a problem hiding this comment.
I'd apply de morgan's here
if args.size != other.args.size ||
...
|
needs a format, somehow you managed to add extra spaces. |
RX14
approved these changes
Mar 28, 2018
sdogruyol
added
kind:bug
sdogruyol
approved these changes
Apr 14, 2018
|
Cool, thank you 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is my first PR in the compiler, deep into the semantic pass 🎉
Fixes #5769
I added a few comments here and there to help me understand what some parts does, I can remove them if needed. I also fixed a bad argument name (
a_def=>a_macro) in 2 macro-related methods.I'll add more specs later if you think what I did is correct.
Thank you!