Fix parsing an empty heredoc #5602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makenowjust
force-pushed
the
fix/crystal/empty-heredoc
branch
from
6e897e3 to
e3ee9a2
Compare
makenowjust
force-pushed
the
fix/crystal/empty-heredoc
branch
from
e3ee9a2 to
e61dbe8
Compare
ysbaddaden
approved these changes
Jan 18, 2018
asterite
approved these changes
Jan 18, 2018
asterite
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler raises an error
"unterminated heredoc"against this:And this code can be compiled:
This PR fixes parsing an empty heredoc correctly. I'm not sure an empty heredoc is useful, but the current behavior is a bug surely.