Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move win32 stubs into a separate file #5484

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Dec 30, 2017

A matter of taste, but I think it's cleaner this way - we can aim to eliminate the windows_stubs.cr file once we have a fairly complete port.

Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comments regarding skip_file vs skip_file()


{% skip_file() %}
{% end %}
{% skip_file() if flag?(:win32) %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably use skip_file here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was waiting for #5493 to make this change all at once.

def read_utf8(io, slice)
raise NotImplementedError.new("IO::Decoder#read_utf8")
end
{% skip_file() if flag?(:win32) %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@RX14 RX14 added kind:refactor topic:stdlib platform:windows Windows support based on the MSVC toolchain / Win32 API labels Jan 2, 2018
@RX14 RX14 merged commit f6e7c2e into crystal-lang:master Jan 2, 2018
@RX14 RX14 added this to the Next milestone Jan 2, 2018
lukeasrodgers pushed a commit to lukeasrodgers/crystal that referenced this pull request Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants