Remove c/winapi and rename some windows types #5448
Conversation
winapi.cr used old and outdated conventions regarding the windows porting effort. It is deleted, and the definitions in it which are used are moved to files corresponding to the windows header they are defined in. Some windows types are also renamed to retain their capitalisation from Microsoft's headers.
RX14
force-pushed
the
feature/remove-winapi
branch
from
1afb3a2 to
043db7a
Compare
| @@ -0,0 +1,3 @@ | |||
| lib LibC | |||
| alias LPSTR = Char* | |||
There was a problem hiding this comment.
Is it wise to alias LPSTR as a pointer to Char?
In WinNT.h it is declared as a pointer of CHAR which is a 1-byte character only.
Reading a pointer of Char from windows API shouldn't be any issue but it will fail if it is populated from Crystal with multibyte characters.
There was a problem hiding this comment.
It should probably better be
alias CHAR = UInt8
alias LPSTR = CHAR*There was a problem hiding this comment.
Char is LibC::Char which is UInt8...
There was a problem hiding this comment.
Oh, I missed that. Still, would it make sense to add an uppercase alias CHAR as in WinNT.h?
There was a problem hiding this comment.
I'd rather not duplicate all the existing libc constants just in upper case just for windows.
|
Ping, this is a really tiny change that affects only windows, this should be simple to review. |
RX14
added
kind:refactor
topic:stdlib
platform:windows
winapi.cr used old and outdated conventions regarding the windows porting effort. It is deleted, and the definitions in it which are used are moved to files corresponding to the windows header they are defined in. Some windows types are also renamed to retain their capitalisation from Microsoft's headers.
winapi.cr used old and outdated conventions regarding the windows porting effort. It is deleted, and the definitions in it which are used are moved to files corresponding to the windows header they are defined in.
Some windows types are also renamed to retain their capitalisation from Microsoft's headers.