Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default argument to Number#round #5397

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Add default argument to Number#round #5397

merged 1 commit into from
Dec 21, 2017

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Dec 17, 2017

Number#round -> Number#round(0, 10)

@Sija Sija mentioned this pull request Dec 17, 2017
Merged
@Sija
Copy link
Contributor Author

Sija commented Dec 20, 2017

Could we get this merged?

@Sija
Copy link
Contributor Author

Sija commented Dec 21, 2017

@jhass @mverzilli @ysbaddaden plz review ❤️

@mverzilli mverzilli merged commit 2d799c7 into crystal-lang:master Dec 21, 2017
@RX14 RX14 modified the milestones: Next, 0.24.1 Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@mverzilli mverzilli mverzilli approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Sija @mverzilli @RX14