Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix matching nested type references in markdown renderer #5308

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Docs: Fix matching nested type references in markdown renderer #5308

merged 1 commit into from
Dec 18, 2017

Conversation

straight-shoota
Copy link
Member

Closes #5293

@RX14
Copy link
Contributor

RX14 commented Nov 18, 2017 •
edited
Loading

Is there a place where this could be specced?

@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs labels Nov 18, 2017
@straight-shoota
Copy link
Member Author

Unfortunately not, at least I couldn't find any. That's why I created #5309

@RX14
Copy link
Contributor

RX14 commented Nov 18, 2017

@straight-shoota yeah I saw that right after this issue. Why not just create a place?

@straight-shoota
Copy link
Member Author

straight-shoota commented Nov 18, 2017 •
edited
Loading

I couldn't see an easy way to test just that change so I figured it would be to much to bootstrap a docs generator test setup just for this small fix.
Maybe it could also help to put some thought into how these specs should be laid out, hence the dedicated issue.

@Sija
Copy link
Contributor

Sija commented Dec 16, 2017

Will it merge?

@RX14
Copy link
Contributor

RX14 commented Dec 17, 2017 •
edited
Loading

@Sija hopefully, although I do need someone from the core team to agree with me.

@Sija
Copy link
Contributor

Sija commented Dec 17, 2017 •
edited
Loading

@bcardiff @asterite @mverzilli?

@mverzilli mverzilli merged commit 88147d0 into crystal-lang:master Dec 18, 2017
@mverzilli mverzilli added this to the Next milestone Dec 18, 2017
@straight-shoota straight-shoota deleted the jm-issue-5293 branch December 18, 2017 14:10
@RX14 RX14 modified the milestones: 0.24.1, Next Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@mverzilli mverzilli mverzilli approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@straight-shoota @RX14 @Sija @mverzilli