Detect recursive structs through tuples, named tuples and recursive aliases #5156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4454
Fixes #4455
This compiles right now but shouldn't:
Since a tuple is like a struct, the representation of
Foo
would expand infinitely. A check was missing regarding tuples and named tuples (first two commits).Likewise, this compiles but shouldn't:
The problem is that the representation of
Bar
in memory is that of Foo, which is recursive, and since recursive aliases are represented as structs this leads to undefined behavior (random crashes).Now, while fixing this I realized recursive aliases are not needed in the language but until (and if) we remove recursive aliases this fixes those bugs, and also fixes potential bugs regarding tuples.