-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't remove docs in block yielding of macro #3778
Don't remove docs in block yielding of macro #3778
Conversation
Good catch! The |
@asterite Thanks! I'll fix it. |
@makenowjust Great, thank you!! :-) Now that I think about it, the comments are probably missing too when you declare a type inside record Foo do
# Bar comment
record Bar
# Baz comment
class Baz
end
end This is because |
@asterite I think it is no problem. Because |
@makenowjust ありがとう! |
@asterite Muchas gracias |
For example, we have a below code:
then run
crystal doc
, we get such a doc:There are no
Foo#super_foo
doc comment, it is just wrong. I fixed it by addingemit_doc
optional arg toASTNode#to_s
and using it in macro interpreter.