Change Process::Status#to_s to hex format on Windows
#15285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
feat/process-status-stringify-windows
branch
from
22a0d62 to
40501f0
Compare
RX14
approved these changes
Dec 18, 2024
ysbaddaden
approved these changes
Dec 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status numbers on Windows are usually represented in hexadecimal notation. This applies that for all large exit status values (above
UInt16::MAX, inspired from https://cs.opensource.google/go/go/+/refs/tags/go1.23.4:src/os/exec_posix.go;l=117-121).This again improves usability because it's easier to interpret unknown status values and compare them with listings sharing the typical number format.
In #15283 we already changed
Status#to_sto print the name of known values. But not all status codes are named.Follow-up on #15267