EventLoop: yield fibers internally [fixup #14996] #15215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior doesn't change: it keeps enqueueing the fiber immediately, but we can now change the behavior at a higher level and a single place, or have an alternative method that could collect the fibers for example. Note that `#close` keeps simply enqueueing waiting fibers one by one.
straight-shoota
approved these changes
Nov 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the internals of the epoll/kqueue event loop to
yieldthe fiber(s) to be resumed instead of blindly callingCrystal::Scheduler.enqueue, so the#runmethod becomes the one place responsible to enqueue the fibers.The current behavior doesn't change, the
#runmethod still enqueues the fiber immediately, but it can now be changed in a single place.For example the execution context shard monkey-patches an alternative
#runmethod that collects and returns fibers to avoid parallel enqueues from an evloop run to interrupt the evloop run (:sob:).Note that the
#closemethod still directly enqueues waiting fibers one by one, for now.