Make MinGW-w64 build artifact a full installation #15204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
topic:infrastructure/ci
platform:windows-gnu
RX14
reviewed
Nov 19, 2024
| @@ -66,34 +61,37 @@ jobs: | |||
| mingw-w64-ucrt-x86_64-llvm | |||
| mingw-w64-ucrt-x86_64-libffi | |||
|
|
|||
| - name: Disable CRLF line ending substitution | |||
| run: | | |||
| git config --global core.autocrlf false | |||
There was a problem hiding this comment.
If this is needed, perhaps .gitattributes should be updated in the crystal repo to fix the line endings on a per-filetype basis.
There was a problem hiding this comment.
It's already there, this is done to err on the side of caution like all other Windows workflows
There was a problem hiding this comment.
Ah, I didn't realise. If the others are like this, let's keep it but I think it'd be nice to turn it off in another PR to get CI warnings when gitattributes is wrong.
straight-shoota
approved these changes
Nov 19, 2024
RX14
approved these changes
Nov 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the MinGW-w64 build artifact included only the compiler itself, all dependent DLLs, and the standard library. This PR turns that into a full installation using
make install, most notably including the license file. There are no changes to functionality.