Use our own libffi repository on Windows CI
#14998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:refactor
platform:windows
|
question: Why not put the repo directly into |
|
I always thought this was restricted to admins but apparently it isn't so? |
|
I think you should be able to create repositories in |
straight-shoota
approved these changes
Sep 16, 2024
straight-shoota
changed the title
libffi repository on Windows CI
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #14802.
It was only a matter of time, but I decided to fork the libffi upstream and write my own
CMakeLists.txt. It only handles x64 MSVC, but we could easily extend it to support ARM64 in the near future. Note that the Windows CI already uses libffi since there are interpreter tests and stdlib tests running with the interpreter.If we are confident that it works then we should later transfer ownership of the fork to crystal-lang (I will continue to maintain it).