Add methods to Crystal::EventLoop
#14977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my, trying to resolve the event loop in a finalizer led to a big segfault on linux because it tried to access it before something got initialized (e.g. the thread or main fiber). We need a safe way to access the current evloop which can return https://github.com/crystal-lang/crystal/actions/runs/10736339467/job/29775532447 |
straight-shoota
approved these changes
Sep 6, 2024
straight-shoota
changed the title
Crystal::EventLoop
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
#after_fork_before_execto allow an evloop to do some cleanup before exec (UNIX only).Add
#remove(io)to allow an evloop to free resources when the IO is closed in a GC finalizer.Extracted from #14959