Fix: Crystal::SpinLock doesn't need to be allocated on the HEAP
#14972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abstraction is a mere abstraction over an atomic integer and the object itself are only ever used internally of other objects, with the exception of Channel where the code explicitely accesses the ivar directly (thus not making copies). We can avoid a HEAP allocation everywhere we use them (i.e. in lots of places).
straight-shoota
approved these changes
Sep 5, 2024
straight-shoota
changed the title
Crystal::SpinLock doesn't need to be allocated in the HEAP
straight-shoota
changed the title
Crystal::SpinLock doesn't need to be allocated in the HEAPCrystal::SpinLock doesn't need to be allocated on the HEAP
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object is a mere abstraction over an atomic integer and the object itself are only ever used internally of other objects and not shared, with the exception of Channel where the code explicitly accesses the ivar directly (still no copies).
We can avoid a HEAP allocation everywhere we use them (i.e. in lots of places).
Extracted from #14959