Add Regex::CompileOptions::MULTILINE_ONLY
#14870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
requested changes
Aug 6, 2024
Sija
reviewed
Aug 6, 2024
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
straight-shoota
changed the title
Regex::CompileOptions::MULTILINE_ONLY
|
Re-added the special handling for MULTILINE (setting MULTILINE and DOTALL) because removing it broke a test. The remaining test failure happens on main too (at spec/std/regex_spec.cr:19) |
There was a problem hiding this comment.
The case for MULTILINE is only necessary because the value of MULTILINE_ONLY is not a composite of MULTILINE. Change it to 0x0000_0004 and it should work.
And the test failure is in fact introduced by this change because the test uses 0x0000_0040 as an undefined option value (but is now defined).
Co-authored-by: Johannes Müller <[email protected]>
straight-shoota
approved these changes
Sep 17, 2024
ysbaddaden
approved these changes
Sep 27, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new MULTILINE_ONLY flag to regexes.
I created an issue here:
#14869
As discussed here:
https://forum.crystal-lang.org/t/regex-that-is-multiline-but-not-dotall-how/7054/12