-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler: refactor codegen #14760
Merged
straight-shoota
merged 4 commits into
crystal-lang:master
from
ysbaddaden:refactor/compiler-parallel-codegen
Aug 6, 2024
Merged
Compiler: refactor codegen #14760
straight-shoota
merged 4 commits into
crystal-lang:master
from
ysbaddaden:refactor/compiler-parallel-codegen
Aug 6, 2024
+98
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
commented
Jun 27, 2024
EDIT: the issue is the legacy crystal compiler in the images (1.0.0 by default 😱) that doesn't support the |
Actually, I prefer the version with a single |
ysbaddaden
changed the title
Compiler codegen: small refactor
Compiler codegen: small refactor with progress fix
Jun 27, 2024
6 tasks
We only need to update unit.reused_compilation_unit? from forked process then have print_codegen_stats count & filter the units.
ysbaddaden
force-pushed
the
refactor/compiler-parallel-codegen
branch
from
July 2, 2024 10:01
162c8b0
to
b17db55
Compare
ysbaddaden
changed the title
Compiler codegen: small refactor with progress fix
Compiler: refactor codegen
Jul 2, 2024
straight-shoota
approved these changes
Jul 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
Crystal::Compiler
:#sequential_codegen
,#parallel_codegen
and#fork_codegen
methods;#codegen_many_units
into#codegen
directly;#fork_codegen
now updatesCompilationUnit#reused_compilation_unit?
state as reported by the forked processes, and#print_codegen_stats
now counts & filters the reused units.Prerequisite for #14748 that will introduce
#mt_codegen
.