-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventLoop#run(blocking)
and EventLoop#interrupt
#14568
Merged
straight-shoota
merged 7 commits into
crystal-lang:master
from
ysbaddaden:feature/nonblocking-and-interruptible-event-loop
May 22, 2024
Merged
Add EventLoop#run(blocking)
and EventLoop#interrupt
#14568
straight-shoota
merged 7 commits into
crystal-lang:master
from
ysbaddaden:feature/nonblocking-and-interruptible-event-loop
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IOCP implementation hasn't been tested, yet.
16 tasks
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/curious-about-the-eventloop-updates/6825/1 |
straight-shoota
changed the title
Add EventLoop#run(blocking) and EventLoop#interrupt
Add May 7, 2024
EventLoop#run(blocking)
and EventLoop#interrupt
straight-shoota
approved these changes
May 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a couple methods to run the event loop in non-blocking mode in addition to the blocking mode, plus the ability to interrupt a blocked thread. This adds the ability to:
These features aren't needed right now, but that will change with RFC 0002.
Both the libevent and IOCP implementations have been manually tested.