Skip building llvm_ext.cc on LLVM 18 or above
#14357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+83
to
+87
| ifneq ($(LLVM_VERSION),) | ||
| ifeq ($(shell test $(firstword $(subst ., ,$(LLVM_VERSION))) -ge 18; echo $$?),0) | ||
| DEPS = | ||
| endif | ||
| endif |
There was a problem hiding this comment.
suggestion: Could we move this visually closer to the definition of DEPS to make it easier to reason about?
Or even put everything into a single conditional?
if (LLVM < 18)
DEPS = $(LLVM_EXT_OBJ)
else
DEPS =
endif
straight-shoota
approved these changes
Mar 11, 2024
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/upcoming-1-12-0-release/6714/1 |
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is still possible to build the empty object file by doing
make llvm_extexplicitly, but that doesn't matter asLibLLVMExt's@[Link]annotation should never be used to populate the linker arguments anyway.