Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some line endings from CRLF to LF #14299

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Change some line endings from CRLF to LF #14299

merged 2 commits into from
Feb 21, 2024

Conversation

HertzDevil
Copy link
Contributor

The only remaining files that still use CRLF should be:

  • bin/crystal.bat
  • bin/crystal.ps1
  • etc/msvc/crystal.natvis
  • etc/win-ci/*.ps1
  • etc/win-ci/crystal.iss
  • Makefile.win
  • samples/Makefile.win

@straight-shoota
Copy link
Member

I'm wondering if we should put those paths into .gitattributes with eol=crlf and a default entry with eol=lf? 🤔

@straight-shoota straight-shoota added this to the 1.12.0 milestone Feb 19, 2024
@straight-shoota straight-shoota merged commit 0565b86 into crystal-lang:master Feb 21, 2024
57 checks passed
@HertzDevil HertzDevil deleted the chore/crlf branch February 21, 2024 12:11
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:chore topic:infrastructure
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota