Move most of spec runner's state into Spec::CLI
#14170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Jan 9, 2024
|
Love this! I've had this on my TODO for so long but haven't had time. Thanks for digging into it! |
1 task
hanneskaeufler
added a commit
to hanneskaeufler/crytic
that referenced
this pull request
May 20, 2024
See crystal-lang/crystal#14170 for the upstream change that broke it
hanneskaeufler
added a commit
to hanneskaeufler/crytic
that referenced
this pull request
May 20, 2024
* Bump to crystal 1.12.1 * Bump ameba and fix violations * Bump to v9 * Regenerate docs * Mark release 9.0.0 * Make fail fast work again See crystal-lang/crystal#14170 for the upstream change that broke it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines most of
Spec's global state into a newSpec::CLIclass, with the end goal of making the spec runner itself more reusable and testable. The new singleton state isSpec.cli; eventually, onlySpec's public class methods should delegate to this singleton, and methods within the runner shouldn't refer to it. The remaining class variables are:Spec::RootContext.@@instanceSpec::RootContext.@@current_contextSpec::RootContext.@@spec_nestingSpec::Example.@@example_counterSpec.@@lines_cacheClass methods of
Specthat should have beennodocare marked as deprecated.