Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more std tests for interpreter #14016

Conversation

cyangle
Copy link
Contributor

@cyangle cyangle commented Nov 24, 2023

This is only a workaround for #12241

It requires setting env var HANDLE_SIGNAL_IN_INTERPRETER to 1 to enable the workaround

Below loop now works without issues:

loop do
  puts `ls`
end

I think this patch is fine as it's behind a flag and interpreter is still experimental.

@straight-shoota

This is only a workaround to make forking work in interpreter
It requires setting env var HANDLE_SIGNAL_IN_INTERPRETER to 1 to enable the workaround
@cyangle cyangle marked this pull request as ready for review November 24, 2023 04:45
@straight-shoota
Copy link
Member

What's the point though? I'd rather try to find a fix for #12241 than implement a workaround just to be able to run more specs.

@cyangle
Copy link
Contributor Author

cyangle commented Nov 26, 2023

Close with alternative workaround #14019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants