Remove LLVMExtCreateMCJITCompilerForModule from llvm_ext.cc
#13966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
straight-shoota
approved these changes
Nov 9, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #13946.
There is no need to disable GlobalISel immediately upon JIT compiler creation, because the target machine can be retrieved afterwards via the LLVM C API, and with it we could use the much shorter
LLVMExtTargetMachineEnableGlobalIselinstead (which will be available in LLVM 18 too).LLVMExtCreateMCJITCompilerForModuledoesn't do anything extra other than updating the target machine's option (twice).