Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid integers in compiler's CLI #13959

Merged

Conversation

HertzDevil
Copy link
Contributor

Uses #to_i? instead of #to_i so that invalid integers do not raise an internal compiler error.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:cli labels Nov 7, 2023
@straight-shoota straight-shoota added this to the 1.11.0 milestone Nov 7, 2023
@straight-shoota straight-shoota merged commit 0bde50b into crystal-lang:master Nov 8, 2023
53 of 55 checks passed
@HertzDevil HertzDevil deleted the bug/compiler-command-to_i branch November 9, 2023 05:59
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants