Fix Globber.constant_entry? matching patterns

[GeopJr]

fix: #13954

This PR adds '{', '[', '\\' to Globber's constant_entry? so it matches patterns that include them without * or ?

[GeopJr]

Not sure if the spec files will cause issues on windows since they have backslashes and asterisks in their filenames

edit: they did

[GeopJr]

Hey @HertzDevil any idea what's going on with Windows? https://github.com/crystal-lang/crystal/actions/runs/6762195146/job/18378622061

[HertzDevil]

The Dir.glob specs use datapath from spec/std/spec_helper.cr, which always returns a native path. Previously things would continue to work as long as the constant directories are still separated from the rest of the segments using /:

Dir.glob(%q(spec/std/data/dir\*.txt)) # => []
Dir.glob(%q(spec\std\data\dir/*.txt)) # => ["spec\\std\\data\\dir\\f1.txt", "spec\\std\\data\\dir\\f2.txt", "spec\\std\\data\\dir\\g2.txt"]

But if Dir.glob uses the same patterns as File.match? and the docs already say that \ is not a directory separator, then those specs are indeed using datapath incorrectly. All those specs must be modified:

# okay
Dir["#{Path[datapath].to_posix}/dir/*.txt"].sort.should eq [
  datapath("dir", "f1.txt"),
  datapath("dir", "f2.txt"),
  datapath("dir", "g2.txt"),
].sort

Note that this pertains to String arguments only. Dir.glob converts Path arguments like this, something File.match? doesn't do:

crystal/src/dir/glob.cr

Lines 153 to 155 in 72e6b02

	if pattern.is_a?(Path)
	pattern = pattern.to_posix.to_s
	end

[GeopJr]

Thanks for the info! I converted them to Path[datapath].to_posix

[GeopJr]

This seems to affect stuff outside the glob spec. I don't think I can do much without a Windows machine, feel free to take over this PR!