Drop Char::Reader#@end
#13920
Merged
Drop Char::Reader#@end
#13920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
approved these changes
Oct 31, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #13817 which removed one of the two places that read the value of
Char::Reader#@end. It was replaced by a comparison@pos < @string.bytesize. This expression is always quivalent to@end, so it's entirely redundant.This patch removes the remaining use in
#has_next?and removes the instance variable entirely.Additionaly, the implementation of
#eachswitches back to use#has_next?as it was before #13817.See also #13816 for some prior discussion.