-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary file check for CLI arguments #13853
Remove unnecessary file check for CLI arguments #13853
Conversation
What happens if there is a compilation error and the compiler tries to read the source code again? (This isn't exclusive to those files of course, it more or less broke |
Well, then it may not be able to read the source code. But that's not a big deal. It's the same when |
We do keep them in memory somewhere, the compiler just doesn't use them yet. My main concern here is whether a blocking read is possible simply from showing a compilation error, making it indistinguishable from an infinite loop |
No, that can't happen. Every time the compiler reloads a raw source, there's an explicit |
Resolves #13849
This patch momentarily degrades the error UX because read errors do not mention which file they appear on. That should improve with #13852 though, so I'm not taking any extra measures here.