Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix free variable matching of bound numeric values #13606

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Fix free variable matching of bound numeric values #13606

merged 2 commits into from
Jun 30, 2023

Conversation

HertzDevil
Copy link
Contributor

Fixes #13605.

Also renames a few things in Crystal::MatchContext for clarity.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:refactor topic:compiler:generics kind:regression Something that used to correctly work but no longer works labels Jun 28, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone Jun 28, 2023
@straight-shoota straight-shoota merged commit ab36532 into crystal-lang:master Jun 30, 2023
@HertzDevil HertzDevil deleted the bug/bound-number-free-variable branch June 30, 2023 17:24
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
@HertzDevil @Blacksmoke16
Fix free variable matching of bound numeric values (crystal-lang#13606)
af2fe98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:refactor kind:regression Something that used to correctly work but no longer works topic:compiler:generics
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Free variables bound to numeric values cannot be matched
2 participants
@HertzDevil @straight-shoota