Refactor symbol quoting into Symbol.quote_for_named_argument
#13595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every call to
Symbol.needs_quotes_for_named_argument?
in the compiler and stdlib is used in the same manner to decide whether to use the parameter directly or with inspect. All call sites look like this:This PR extracts that common logic into a helper method
Symbol.quote_for_named_argument
.Like
.needs_quotes_for_named_argument?
, it's nodoc.All calls to
Symbol.needs_quotes_for_named_argument?
are replaced bySymbol.quote_for_named_argument
, and the former is marked as deprecated.It's a nodoc method, so this would not be absolutely necessary and we could just remove it right away. But it's still nice to keep it available for some time (at least till the next release).