-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Display Bool
's size as 1 byte in crystal tool hierarchy
, not 0
#13588
Fix: Display Bool
's size as 1 byte in crystal tool hierarchy
, not 0
#13588
Conversation
Bool
's size as 1 byte in crystal tool hierarchy
Bool
's size as 1 byte in crystal tool hierarchy
, not 0
@HertzDevil There are some CI failures which seem to originate from this change. |
Apparently this is breaking the interpreter because crystal/src/compiler/crystal/codegen/llvm_typer.cr Lines 248 to 251 in 52b8e3b
This was ultimately introduced in 08fa6cd. If a module type truly has no includers then it is effectively EDIT: this broke codegen specs |
This reverts commit cbd0df1.
We are doing the right thing here. The file-private scope type should never have been passed around and some checks in the interpreter are most likely inconsistent with normal codegen |
Bool
's size as 1 byte in crystal tool hierarchy
, not 0Bool
's size as 1 byte in crystal tool hierarchy
, not 0
This is a more general fix than #8273 that works for any LLVM integer type whose bit width is not a multiple of 8 (although Crystal only uses
i1
).