Build Windows portable and installer packages on CI #13578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
topic:infrastructure
platform:windows
Both builds steps are basically identical except for one config setting. So it would be great to avoid the duplication of the ~15 steps that are exactly the same in each. |
straight-shoota
approved these changes
Jun 30, 2023
Blacksmoke16
pushed a commit
to Blacksmoke16/crystal
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Inno Setup script, and builds both the portable and installer packages in the Windows GitHub workflow. Resolves #13426.
The portable package is built in release mode and comes with
crystal.pdb; otherwise, it is identical to the unofficial package we are already distributing. The Inno Setup script expects this portable package to be available atetc\win-ci\portable, and then builds an installer from it, plus samples and offline docs.The installer will instruct the user to install the MSVC build tools and/or the Windows SDK manually if they are not detected.
Right now both jobs will unconditionally run on any push or PR, but this is only so that the PR itself and the master branch would build the packages for testing; the jobs will afterwards be restricted to branches named
ci/*orrelease/*. The eventual goal here is to avoid having to rebuild all third-party libraries on every nightly build once these packages are ready.