Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not drop /LIBPATH from Windows linker command #13530

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Fix: Do not drop /LIBPATH from Windows linker command #13530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d7977f
Do not drop `/LIBPATH` from Windows linker command
HertzDevil May 30, 2023
3d9a88b
fixup
HertzDevil May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/compiler/crystal/loader/msvc.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,13 @@ class Crystal::Loader
extra_search_paths = [] of String

args.each do |arg|
if lib_path = arg.lchop?("/LIBPATH:")
extra_search_paths << lib_path
elsif !arg.starts_with?('/') && (name = arg.rchop?(".lib"))
if !arg.starts_with?('/') && (name = arg.rchop?(".lib"))
libnames << name
elsif remaining
remaining << arg
else
remaining << arg if remaining
if lib_path = arg.lchop?("/LIBPATH:")
extra_search_paths << lib_path
end
end
end

Expand Down