Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of Iterator#chunk and Enumerable#chunks without Drop #13506

Merged

Conversation

straight-shoota
Copy link
Member

resolves #13396

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:collection labels May 26, 2023
@straight-shoota straight-shoota self-assigned this May 26, 2023
@straight-shoota straight-shoota changed the title Fix return type of Iterator#chunk and Enumerable#chunks without Drop Fix return type of Iterator#chunk and Enumerable#chunks without Drop May 26, 2023
@beta-ziliani beta-ziliani requested a review from HertzDevil June 5, 2023 13:10
src/enumerable.cr Outdated Show resolved Hide resolved
src/enumerable.cr Outdated Show resolved Hide resolved
src/enumerable.cr Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.9.0 milestone Jun 6, 2023
@straight-shoota straight-shoota merged commit 2f38e16 into crystal-lang:master Jun 14, 2023
@straight-shoota straight-shoota deleted the fix/enumerable-chunk-type branch June 14, 2023 13:11
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return type of Iterator#chunk and Enumerable#chunks includes Enumerable::Chunk::Drop
3 participants