Fix for Process: ensure chdir is a string

[devnote-dev]

This fix prevents the following compile-time error by ensuring that #to_s is called for Path and String:

In C:\Users\user\Documents\Crystal\Windows\src\crystal\system\win32\process.cr:210:75

 210 | make_env_block(env, clear_env), chdir.try { |str| System.to_wstr(str) },
                                                                        ^--
Error: expected argument #1 to 'Crystal::System.to_wstr' to be String, not Path

Overloads are:
 - Crystal::System.to_wstr(str : String, name : String | ::Nil = nil)

[HertzDevil]

Is there a spec for this?

[devnote-dev]

No, and given that Process#run is the only method that is affected by this, I don't think that it's necessary to have specs for such a tiny issue.

[HertzDevil]

If something doesn't compile, it isn't tiny at all

[devnote-dev]

Right, but given how infrequently the process.cr file changes (ignoring documentation/formatting), and how long this issue has actually been here undetected, I don't think specs for it are really needed. Clearly it hasn't been an issue for the majority that do use it.

[HertzDevil]

crystal/CONTRIBUTING.md

Line 150 in 0627b47

4. Any change to behaviour needs to be reflected and validated with specs.

So you are saying this bugfix doesn't deserve a spec because you belong to a minority?

[devnote-dev]

No, I would make the same argument if this affected platforms other than Windows. My point is the change is so small that I think having specs for it isn't necessary. That doesn't invalidate the fact that it didn't compile beforehand, but I don't see it as something so significant that specs would be necessary for it.