Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slow tag to stdlib specs that compile a program #13498

Merged
merged 3 commits into from
May 26, 2023
Merged

Add slow tag to stdlib specs that compile a program #13498

merged 3 commits into from
May 26, 2023

Conversation

straight-shoota
Copy link
Member

No description provided.

@straight-shoota straight-shoota self-assigned this May 23, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone May 23, 2023
@HertzDevil
Copy link
Contributor

HertzDevil commented May 24, 2023 •
edited
Loading

Some more specs that you may want to tag:

  • compile_file (ones in kernel_spec.cr and exception/call_stack_spec.cr)
  • compile_and_run_file (ones in exception/call_stack_spec.cr)
  • compile_and_run_source (mainly ones in kernel_spec.cr)
  • compile_and_run_source_with_c (one in va_list_spec.cr)
  • there is one commented-out spec for String#strip that calls for a slow tag

@straight-shoota straight-shoota removed this from the 1.9.0 milestone May 24, 2023
HertzDevil
HertzDevil requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@HertzDevil HertzDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more compile_and_run_source missing in spec/std/process_spec.cr and spec/std/spec/hooks_spec.cr

@straight-shoota straight-shoota added this to the 1.9.0 milestone May 25, 2023
@straight-shoota straight-shoota merged commit 341b1ef into crystal-lang:master May 26, 2023
@straight-shoota straight-shoota deleted the feature/slow-tag branch May 26, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:specs topic:stdlib:files
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @HertzDevil