Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Socket checks WinError.wsa_value on Windows, not Errno.value #13494

Merged
merged 2 commits into from
May 24, 2023
Merged

Ensure Socket checks WinError.wsa_value on Windows, not Errno.value #13494

merged 2 commits into from
May 24, 2023

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented May 23, 2023 •
edited
Loading

Discovered during #13493

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:networking labels May 23, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone May 23, 2023
@straight-shoota straight-shoota merged commit 93cb352 into crystal-lang:master May 24, 2023
@HertzDevil HertzDevil deleted the bug/windows-socket-errno branch May 24, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:networking
Projects
Windows Support
Status: Done
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HertzDevil @straight-shoota