Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File.info(File::NULL) on Windows #13421

Merged
merged 1 commit into from
May 3, 2023

Conversation

HertzDevil
Copy link
Contributor

This makes the class method return the same thing as File.open(File::NULL).info on Windows, since the bulk of the implementation already exists for the latter.

The returned File::Info has no fields set other than @file_type. This is the same as calling File#info on a file descriptor returned by IO.pipe.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files labels May 2, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone May 2, 2023
@straight-shoota straight-shoota merged commit 3226a35 into crystal-lang:master May 3, 2023
@HertzDevil HertzDevil deleted the bug/file-null-info branch May 3, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants