Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: Don't skip the token immediately after lib name #13407

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Parser: Don't skip the token immediately after lib name #13407

merged 2 commits into from
Apr 28, 2023

Conversation

FnControlOption
Copy link
Contributor

@FnControlOption FnControlOption commented Apr 27, 2023 •
edited
Loading

For example, lib Foo%end should raise a syntax error because of the %

Found this bug while working on #13375

HertzDevil
HertzDevil requested changes Apr 27, 2023
View reviewed changes
spec/support/syntax.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels Apr 27, 2023
@straight-shoota straight-shoota added this to the 1.9.0 milestone Apr 27, 2023
@straight-shoota straight-shoota merged commit 8bc95c1 into crystal-lang:master Apr 28, 2023
@FnControlOption FnControlOption deleted the lib branch May 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@FnControlOption @straight-shoota @HertzDevil