Fix Array#flatten
to discard Iterator::Stop
#13388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
Array#flatten
with an iterator as part of the flattened collections, the resulting array would haveIterator::Stop
as part of the element type.Iterator::Stop
is just an indicator for the end of an iterator and not part of its elements. So it must be filtered out when typing the flattened array.FlattenHelper
failed to do that.This patch refactors the implementation to be more like
Enumerable.element_type
which has a similar purpose just without flattening.