Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCPSocket#tcp_keepalive_idle on Windows #13364

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Fix TCPSocket#tcp_keepalive_idle on Windows #13364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/std/socket/tcp_socket_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ describe TCPSocket, tags: "network" do
end
end

pending_win32 "settings" do
it "settings" do
port = unused_local_port

TCPServer.open("::", port) do |server|
Expand Down
4 changes: 2 additions & 2 deletions src/crystal/system/win32/socket.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,11 +407,11 @@ module Crystal::System::Socket
end

private def system_tcp_keepalive_idle
getsockopt LibC::SO_KEEPALIVE, 0, level: ::Socket::Protocol::TCP
getsockopt LibC::TCP_KEEPIDLE, 0, level: ::Socket::Protocol::TCP
end

private def system_tcp_keepalive_idle=(val : Int)
setsockopt LibC::SO_KEEPALIVE, val, level: ::Socket::Protocol::TCP
setsockopt LibC::TCP_KEEPIDLE, val, level: ::Socket::Protocol::TCP
val
end

Expand Down