Refactor String header layout reflection #13335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the assumption of
String
s memory layout in stdlib when allocating an instance by hand.The exact memory layout is governed by the compiler (or rather the LLVM backend takes care of the specifics). The assumed layout is probably correct most of the time, but it's not guaranteed.
And it's easy to implement in a way that does not assume anything about the memory layout except that the char array is the last field.
This action decouples the stdlib implementation from compiler internals.
It also paves a way for potential future changes to
String
s layout, for example as suggested in #12020.