Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder and enhance specs for String.new(&) #13333

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Reorder and enhance specs for String.new(&) #13333

merged 3 commits into from
Apr 18, 2023

Conversation

straight-shoota
Copy link
Member

This patch combines some scattered specs for String.new(&) and adds some additional ones.

@straight-shoota straight-shoota self-assigned this Apr 17, 2023
HertzDevil
HertzDevil reviewed Apr 17, 2023
View reviewed changes
spec/std/string_spec.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.9.0 milestone Apr 17, 2023
@straight-shoota straight-shoota merged commit 2300bef into crystal-lang:master Apr 18, 2023
@straight-shoota straight-shoota deleted the spec/string.new-yield branch April 18, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HertzDevil HertzDevil HertzDevil approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:specs topic:stdlib:text
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @HertzDevil