Always use 0 for offset of StaticArray's @buffer
#13319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:bug
|
Happy to confirm the issue is fixed! Thanks. |
straight-shoota
approved these changes
Apr 14, 2023
25 tasks
straight-shoota
pushed a commit
that referenced
this pull request
May 8, 2023
joebonrichie
pushed a commit
to solus-packages/crystal
that referenced
this pull request
Aug 14, 2023
Summary: [Changelog](https://github.com/crystal-lang/crystal/blob/1.8.0/CHANGELOG.md) This build contains fixes for two LLVM assertion failures ([1](crystal-lang/crystal#13305), [2](crystal-lang/crystal#13319)) that previously prevented the compiler specs from passing and interpreter support from working respectively. The latter of these will be released in 1.9.0 but I include it here as a patch. Test Plan: Tested compilation of simple program and `crystal i`. Reviewers: #triage_team, Staudey Reviewed By: #triage_team, Staudey Subscribers: Staudey Differential Revision: https://dev.getsol.us/D13954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13317.
@biqqles I could get the interpreter running without assertion failures after this patch. Can you confirm?Fixes #12589.