Drop MATCH_INVALID_UTF
#13313
Merged
Drop MATCH_INVALID_UTF
#13313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
reviewed
Apr 13, 2023
Sija
reviewed
Apr 13, 2023
| # | ||
| # Unsupported with PCRE. | ||
| # | ||
| # NOTE: This option was introduced in PCRE2 10.34 but a bug that can lead to an |
There was a problem hiding this comment.
That deserves a stronger marker IMO.
Suggested change
| # NOTE: This option was introduced in PCRE2 10.34 but a bug that can lead to an | |
| # WARNING: This option was introduced in PCRE2 10.34 but a bug that can lead to an |
There was a problem hiding this comment.
I think it's fine. If you want to use a feature of any library you must make sure it's supported in the library version you're linking against. That's a general axiom. Here we're just pointing out the relevant versions for this particular option.
There was a problem hiding this comment.
We're pointing not only the version but also the fact it contains a rather serious bug.
HertzDevil
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch drops the implicit
MATCH_INVALID_UTFoption which was added as part of a bug fix in #13240.Instead this option is now available in
Regex::CompileOptionsfor opt-in.Similarly,
NO_CHECK_UTFmembers are added toRegex::CompileOptionsandRegex::MatchOptions.Regex::CompileOptions::NO_CHECK_UTFis identical to the already existing but undocumentedNO_CHECK_UTF8member.Resolves #13312