Make BigRational.new(BigFloat)
exact
#13295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigRational.new(Float::Primitive)
is exact, and so isBigFloat.new(BigRational)
, which GMP provides.BigRational.new(BigFloat)
isn't, because it shares the same overload as primitive floats, and assumes only 52 bits of precision are available in the mantissa:This PR ensures no bits are lost after using
Math.frexp
to decompose the argument.